Batch hash #932
Merged
Batch hash #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iris-mpc-gpu/src/server/actor.rs
Outdated
Comment on lines
1502
to
1507
| let mut valid_merged = vec![false; max_batch_size]; | ||
| for i in 0..self.comms[0].world_size() { | ||
| for j in 0..max_batch_size { | ||
| valid_merged[j] &= results[i][j] == 1; | ||
| } | ||
| } |
There was a problem hiding this comment.
Should we still keep this or fail? seems if we remove some entries than we risk them not being the same signupIds?
There was a problem hiding this comment.
But this can happen all the time. A client can even force this by sending us a wrongly encrypted share.
There was a problem hiding this comment.
This code has been there actually also before, just slightly rewritten, I can also restore the old version
danielle-tfh
approved these changes
Jan 14, 2025
eaypek-tfh
reviewed
Jan 14, 2025
eaypek-tfh
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculates a hash out of the signup ids of the current batch and syncs this hash across the node. This makes sure the queues are actually in sync before starting processing. This just throws an error and the actor can't recover it on its own requiring manual intervention.